This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] fullname attribute for GDB/MI stack frames


> Date: Wed, 4 May 2005 09:34:37 -0400
> From: Daniel Jacobowitz <drow@false.org>
> 
> I consider printing "d:foo.c" to be "asking the user to guess".  We
> didn't tell them where the file was.

We did, as well as we could.

> If GDB has settled on a path, it can fully resolve it and display it to
> the user.  For instance, suppose that the best GDB can glean from the
> debug information is "d:foo".  That's equivalent to "d:./foo".  I
> presume that DJGPP has some concept of "get the current directory on
> drive D".  So GDB could print out "d:/some/directory/foo" instead.
> I also presume that there's an equivalent "get current drive" for the
> "\foo" case.

We could do all that, but (1) it would add more ugly OS-dependent
ifdef's to openp, with no good reason, and (2) for the case in point,
i.e., fixing file names recorded in the debug info, there's still no
guarantee that the result will be correct, for the reasons I already
explained here many times.

> > Then let's do what I suggested: take the value of fullname and see if
> > we can reach the file it names.  There's no need for any regexp at
> > all; moreover, even if we agree on some regexp, it is only a fuzzy
> > test, since the fact that the output matches does not yet mean that
> > the output is correct.
> 
> Then the value GDB uses will be based on its current directory or
> drive, and the value the testsuite uses will be based on its own
> current directory or drive.  I don't think that's an improvement.

Okay, I give up: I no longer care what you do for the test suite in
this case.  Just please, PLEASE, don't change anything in openp or in
xfullpath to ``fix'' this test.  Can we leave this at that?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]