This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] maintenance_print_msymbols: Try harder to match files


> > I don't remember all the details, I could dig up the relevant messages
> > if necessary. But the comment at the begining of the function seems to
> > confirm that this code is correct to be here:
> > 
> >     /* Return a copy of FILENAME, with its directory prefix canonicalized
> >        by gdb_realpath.  */
> > 
> > Perhaps the function is incorrectly named, though (misleading)...
> > Should we consider finding a more meaningful name?
> 
> I would rather see an example of why the current behavior is correct,
> first.

I think I remember the whole story now. The description of the problem
xfullpath fixes is at:

        http://sources.redhat.com/ml/gdb-patches/2002-03/msg00345.html

All the followup messages were refreshing... Basically, we're trying
in xfullpath to avoid canonicalizing the basename part of the path.
So, if the name doesn't have any directory part in it, then we're
done.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]