This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH: gdb/mi + doco] -var-update
- From: Nick Roberts <nickrob at snap dot net dot nz>
- To: Bob Rossi <bob at brasko dot net>
- Cc: Andrew Cagney <cagney at gnu dot org>, gdb-patches at sources dot redhat dot com
- Date: Mon, 2 May 2005 14:06:57 +1200
- Subject: Re: [PATCH: gdb/mi + doco] -var-update
- References: <16919.7660.144228.334687@farnswood.snap.net.nz><01c5167f$Blat.v2.4$9a7a6f60@zahav.net.il><16919.53411.753668.336933@farnswood.snap.net.nz><01c51709$Blat.v2.4$4a3292a0@zahav.net.il><16921.18627.457594.938060@farnswood.snap.net.nz><01c517d0$Blat.v2.4$09a26040@zahav.net.il><16922.43915.346792.973282@farnswood.snap.net.nz><01c51898$Blat.v2.4$f6fd05c0@zahav.net.il><16929.8147.933720.246602@farnswood.snap.net.nz><16955.41017.161288.832646@farnswood.snap.net.nz><20050401024942.GA2179@white>
> I have some spare time waiting for my patches to get reviewed, so I
> figure'd I'd look at yours. If you care, I have just a few comments.
Sorry, Bob. I read this too quickly the first time and (stupidly) thought
that you had forgot to include the comments.
> > + const char novalues[] = "\"--no-values\"";
> > + const char withvalues[] = "\"--with-values\"";
> > + const char simplevalues[] = "\"--simple-values\"";
> > + const char allvalues[] = "\"--all-values\"";
>
> These could be made static.
Not really. I use them in my patch for mi-cmd-stack.c which I included in my
earlier submission (Sun, 27 Feb 2005 14:18:11 +1300) but left out on (Mar 19)
as it was unchanged.
...
> > ! if (strcmp (argv[0], "0") == 0
> > ! || strcmp (argv[0], "--no-values") == 0)
> > ! print_values = PRINT_NO_VALUES;
> > ! else if (strcmp (argv[0], "1") == 0
> > ! || strcmp (argv[0], "--with-values") == 0)
>
> instead of using "--no-values" and "--with-values" you could use the
> variable "novalues" and "withvalues".
Yes. That would make sense.
> > ! if (argc == 2)
> > ! {
> > ! if (strcmp (argv[0], "0") == 0
> > ! || strcmp (argv[0], "--no-values") == 0)
> > ! print_values = PRINT_NO_VALUES;
> > ! else if (strcmp (argv[0], "1") == 0
> > ! || strcmp (argv[0], "--with-values") == 0)
>
> same as above with the --no-values and --with-values
Yes.
I will send the revised source (all files apart from doco which Eli has
already approved) to Daniel and cc gdb-patches.
Nick