This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] New target am33-linux (mn10300)
Date: Sat, 30 Apr 2005 09:58:47 -0400
From: Daniel Jacobowitz <drow@false.org>
On Sat, Apr 30, 2005 at 01:03:16PM +0200, Mark Kettenis wrote:
> It uses DEPRECATED_TM_FILE, and we're not allowd to check in anything
> new that uses it. Unfortunately, this means you can only check this
> in without working shared library stuff. Personally I think we should
> allow "DEPRECATED_TM_FILE= solib.h" until the shared libarry stuff is
> properly fixed. Anyway, you seem to have left out the tm-linux.h that
> you reference.
I actually caught this bit in my review and decided to ignore it. He
didn't leave out his tm-linux.h; he'll get the pre-existing
config/tm-linux.h, and I can make a reasonable argument that this is
not a new use of DEPRECATED_TM_FILE.
Ah, ok. That should be an explicit config/tm-linux.h then. But
that's bad, because that includes some gunk that I'm not sure is
needed anymore. I've never moved towards removing that gunk, since
I'm not confident that it doesn't hurt one of the not-so-mainstream
Linux targets. Adding another target to that list kinda sucks.
Anyway, can you elaborate on why this isn't a new use of
DEPRECATED_TM_FILE? I vividly remember the line
DEPRECATED_TM_FILE= solib.h
being backed out from config/mips/obsd64.mt because it wasn't acceptable.
Mark