Re: [RFA/sim] Resurrect sh64 target

[Corinna Vinschen <vinschen at redhat dot com>]

On Apr 14 13:34, Daniel Jacobowitz wrote:
> On Wed, Mar 30, 2005 at 07:48:17PM +0200, Corinna Vinschen wrote:
> > 	* configure.ac: Add explicit sh64 case.
> > 	* configure: Regenerate.
> > 	* sh64/configure.ac: New file.
> > 	* sh64/configure.in: Remove.
> > 	* sh64/configure: Regenerate.
> > 	* sh64/defs-media.h (sem_fields): Add missing sfmt_ldhil member.
> > 	* sh64/sim-if.c (sim_open): Use struct bfd instead of struct _bfd.
> > 	(sim_create_inferior): Ditto.
> 
> Hi Corinna,
> 
> This patch is fine.  Please fix the space/tab mismatch in
> sim/configure.ac before committing:
> 
> > -       sh*-*-*)
> > +       sh64-*-*)
> > +           AC_CONFIG_SUBDIRS(sh64)
> > +	   testsuite=yes
> > +	   common=yes
> > +	   ;;
> > +       sh-*-*)

I just had a look into this and it turns out that *all* AC_CONFIG_SUBDIRS
lines in the configure.ac file are prefixed with only spaces, while the
other lines (testsuite/common) are prefixed with a tab and 3 spaces.
For now, I decided to keep it as it is and check it in.

I don't know if it makes sense to change this globally in the file, but if
so, just drop a note and I will fix it.

> Also, please don't send diffs to generated files to the list.  I was
> putting off reviewing this because I was intimidated by the 359k file
> size - which turned out to be entirely sim/sh64/configure :-)

I'm terribly sorry.  I usually don't send generated files, it was really
an oversight.  If that happens again, please send a quick note and I'll
resend a patch without generated files, no problem.

Thanks for reviewing!  Applied.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.