This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH: gdb/mi + doco] -var-update
> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Mon, 21 Feb 2005 15:34:43 +1300
> Cc: gdb-patches@sources.redhat.com
>
> > If other messages are marked up with _(), then this is okay. But I
> > still think the const char [] strings should be defined once and used
> > elsewhere in this function.
>
> OK but this only makes sense if it is done consistently. So I offer to
> do it for all of the MI error messages.
It should be done for all messages, yes; but I'd like at least to have
the new messages follow that principle.
> > > I've used "--all-values" because, in the case of -var-list-children there
> > > is a third possibility: "--simple-values" and, to me, it seems simpler to
> > > have only three values for print_values (mi-cmds.h):
> > >
> > > enum print_values {
> > > PRINT_NO_VALUES,
> > > PRINT_ALL_VALUES,
> > > PRINT_SIMPLE_VALUES
> > > };
> >
> > I see the reason, but I think it is not important enough to use
> > "--all-values". Anyway, the switch text does not need to be similar
> > to the enum name, even if you use PRINT_ALL_VALUES in the enum.
>
> OK. But again this only makes sense if I change -var-list-children too.
What change did you have in mind?