Re: [commit] Mark up add_cmd

["Eli Zaretskii" <eliz at gnu dot org>]

> Date: Mon, 14 Feb 2005 20:57:15 -0500
> From: Andrew Cagney <cagney@gnu.org>
> Cc: gdb-patches@sources.redhat.com
> 
> It's taken us three months to get through files a-c, simple math tells 
> us that at that rate we'll finish sometime on '07.  I don't think so.

I don't know why it took so long, but it certainly isn't because of
the time it took to review the patch and post the results.  IIRC, none
of the reviews was ever posted more than a few days after the RFA,
usually only hours since the RFA was received.

So this argument cannot possibly justify your decision to bypass the
normal procedures.

> > Sigh.  I don't know anymore why should I bother reviewing patches when
> > they are committed unconditionally, but here goes anyway...
> 
> As you identify problems, please mark them in the code using a comment 
> of the form:
> 
> 	/* FIXME: i18n: ...

I didn't know that we switched to marking problems instead of fixing
them.  How many FIXME's do we want to have in a released GDB?