This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: Modified Watchthreads Patch


On Fri, Dec 10, 2004 at 03:37:29PM -0500, Daniel Jacobowitz wrote:
> Please fix the whitespace at the end of s390-nat.c.  Otherwise, this is
> approved if Ulrich is OK with the S390 bits; let's give him a chance to
> comment.

Let's hold off while we discuss the observers issue.

Jeff, I've been thinking about this patch, and another problem occured
to me.  You're using a "new thread" event, but you're not iterating
over threads - you're iterating over LWPs.  So whether or not we want
to use an observer for this action, it's in the wrong conceptual place;
on recent systems we should be able to debug multi-threaded programs
that do not use libpthread with some degree of success.  TLS won't
work, of course, since that's library-supported... but most of the rest
of what libthread_db is not necessary.  The code for this on the GDB
side is not completely in place yet but I'm working up to it - that's
one of the goals of the revamped Linux target_ops.

-- 
Daniel Jacobowitz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]