This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] gdbserver: Add support for qGetTLSAddr packet
- From: Andreas Schwab <schwab at suse dot de>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 07 Dec 2004 00:46:45 +0100
- Subject: Re: [RFA] gdbserver: Add support for qGetTLSAddr packet
- References: <20041206152002.551f8d46.kevinb@redhat.com>
Kevin Buettner <kevinb@redhat.com> writes:
> Index: gdbserver/Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/Makefile.in,v
> retrieving revision 1.27
> diff -u -p -r1.27 Makefile.in
> --- gdbserver/Makefile.in 16 Oct 2004 16:18:54 -0000 1.27
> +++ gdbserver/Makefile.in 6 Dec 2004 21:58:56 -0000
> @@ -246,6 +246,8 @@ proc-service.o: proc-service.c $(server_
> regcache.o: regcache.c $(server_h) $(regdef_h)
> remote-utils.o: remote-utils.c terminal.h $(server_h)
> server.o: server.c $(server_h)
> + $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< @USE_THREAD_DB@
IMHO it is preferable to assign any substitution to a variable and use
that in any reference. That makes it easier to override it for debugging
or whatever.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."