This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA fix conversion of little-byte big-word floats to doublest
- From: Daniel Jacobowitz <drow at false dot org>
- To: Richard Earnshaw <Richard dot Earnshaw at buzzard dot freeserve dot co dot uk>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 4 Dec 2004 10:44:30 -0500
- Subject: Re: RFA fix conversion of little-byte big-word floats to doublest
- References: <200412041438.iB4Ec0cq017568@merlin.buzzard.freeserve.co.uk>
On Sat, Dec 04, 2004 at 02:38:00PM +0000, Richard Earnshaw wrote:
>
> This patch fixes a bug in get_field which meant that we incorrectly
> converted mixed-endian floats (ARM FPA style) into the internal doublest
> format. This short change fixes over 300 testsuite failures in a combined
> arm/thumb testsuite run on arm-elf.
>
> * doublest.c (get_field): Correctly extract floatformat_littebyte_bigword
> fields.
>
> OK?
Could you summarize for me how this is supposed to work? This means
that get_field treats littlebyte_bigword exactly the same as little.
There's another copy of get_field in libiberty (I don't know why there
are two) which treats it exactly the same as big, instead. I don't
know how that works either, but it seems the two ought to agree.
--
Daniel Jacobowitz