This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/hppa] Several cleanups for hppa-tdep.c
- From: Mark Kettenis <kettenis at gnu dot org>
- To: randolph at tausq dot org
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 10 Nov 2004 12:07:47 +0100 (CET)
- Subject: Re: [patch/hppa] Several cleanups for hppa-tdep.c
- References: <20041110000026.GA15714@tausq.org>
Date: Tue, 9 Nov 2004 16:00:26 -0800
From: Randolph Chung <randolph@tausq.org>
will commit as obvious tomorrow, unless i hear otherwise.
@@ -1653,7 +1670,8 @@ hppa_frame_cache (struct frame_info *nex
{
int reg;
char buf4[4];
- long status = deprecated_read_memory_nobpt (pc, buf4, sizeof buf4);
+ long status = safe_frame_unwind_memory (next_frame, pc, buf4,
+ sizeof buf4);
long inst = extract_unsigned_integer (buf4, sizeof buf4);
This bit is probably not right. The return value from
safe_frame_unwind_memory is the opposite of
deprecated_read_memory_nobpt.
Hmm, it doesn't seem to matter; the return value isn't used. Some
more cleanups to do ;-). You probably ought to check the return value
though.
Mark