This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Patch to support AMD64 Solaris 10
- From: Andrew Cagney <cagney at gnu dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>, Mark Kettenis <kettenis at gnu dot org>
- Cc: gdb-patches at gcc dot gnu dot org
- Date: Mon, 01 Nov 2004 11:42:59 -0500
- Subject: Re: Patch to support AMD64 Solaris 10
- References: <Pine.LNX.4.61.0410251739090.3442@digraph.polyomino.org.uk>
Joseph, Mark,
GDB's acceptance criteria for patches such as this is pretty clear:
- (C) assignment
tick
- coding standard
just run it through ./gdb_indent.sh
- deprecation
oops
- ./gdb_ari.sh -Wari to flag other looming coding problems
This is often easiest after the event.
The only thing really blocking this patch is ``deprecation''. And
there, the same patch minus the TM file would be acceptable (such a GDB
would even build and to a point work) (notice how test results are not
one of the acceptance criteria ;-).
Joseph, can you submit an up-to-date patch _minus_ the TM file I'll
approve it? By getting that committed we can get the bulk of the patch
off the table. Then we can follow up with smaller patches addressing
each of the remaining problems. First with the missing multi-arch
macros, and second with any concerns with *-nat files.
Does that sound reasonable?
Andrew