This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Change gdbarch_return_value to take function type instead of return value type


   Date: Tue, 12 Oct 2004 14:49:16 +0200
   From: Corinna Vinschen <vinschen@redhat.com>

Hi Corinna,

The patch looks OK to me.

   There's also an important change necessary to sparc-tdep.c.  sparc32 is the
   only platform which calls using_struct_return from push_dummy_code.  Since
   push_dummy_code only has the return value type, it can neither call 
   using_struct_return nor gdbarch_return_value.  I've created a new static
   function called "sparc32_using_struct_return" which only evaluates whether
   a struct return condition exists or not.  The function is now used in
   sparc32_push_dummy_code as well as in sparc32_return_value.

I think that for HP-UX, push_dummy_call needs to get passed the
function as a `struct value'.  That could clean up things a bit
further.  However, that's not for you to worry about.  So please check
this in.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]