This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/mips] Proposal for inlining heuristic_proc_desc a bit...


Hello Andrew,

what would you think of something like this. It's just a concept,
it hasn't been compiled nor tested, but the idea is to remove the
call to heuristic_proc_desc() in mips_insn32_frame_cache() by a
a direct call to mips32_scan_prologue(). The same would be applied
to mips16.

The two things that are not obvious are:

  . Where should the SP be computed: in the caller ofo scan_prologue,
    or inside scan_prologue. I chose the latter.

Yes. One block of code with all the heuristics.


  . Should the scanning limit (200 bytes) be checked in the caller,
    or inside scan_prologue. Again, I chose the latter.

Yes (although I think that limit is bogus :-).


This is mostly to avoid duplicating this code. What do you think?

Consider them pre approved.


You know, heuristic_proc_desc() is in grave danger of dying :-).
I have have a couple of things I'd like to work on first, but then
it should be ripe for removal.

Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]