Re: [RFA] Enhance GDB to break inside DSO init code

[Joel Brobecker <brobecker at gnat dot com>]

Hello Kevin,

> Do you have access to a Solaris box?  If so, could you test for
> regressions there as well?

That's a good idea. So I tested the patch on sparc-solaris2.8 as well,
without any regression.

> If all goes well, I have no objection to this patch going in.  (Consider
> it approved unless someone else says otherwise.)

I didn't see any objection, so I checked the patch in. Thank you for
the review!

> > 2004-07-23  Joel Brobecker  <brobecker@gnat.com>
> > 
> >         * procfs.c (dbx_link_bpt_addr): New static global variable.
> >         (dbx_link_shadow_contents): New static global variable.
> >         (procfs_wait, case <PR_SYSEXIT>): Handle syssgi events.
> >         (procfs_wait, case <FLTBPT>): Remove the __dbx_link brekapoint
> >         if we just hit it.
> >         (procfs_init_inferior): Enable syssgi() syscall trace if appropriate.
> >         Reset dbx_link_bpt_addr as the address of __dbx_link() may change
> >         from run to run.
> >         (procfs_create_inferior): Remove syssgi syscall-exit notifications
> >         after the inferior has been forked.
> >         (remove_dbx_link_breakpoint): New function.
> >         (dbx_link_addr): New function.
> >         (insert_dbx_link_bpt_in_file): New function.
> >         (insert_dbx_link_bpt_in_region): New function.
> >         (insert_dbx_link_breakpoint): New function.
> >         (proc_trace_syscalls_1): New function, extracted from
> >         proc_trace_syscalls.
> >         (proc_trace_syscalls): Replace extract code by call to
> >         proc_trace_syscalls_1.
> >         * solib-irix.c (disable_break): Remove stop_pc assertion, as it
> >         is no longer valid.
> > 
> > Tested on mips-irix, no regression. OK to commit?
-- 
Joel