This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: Fix for pending breakpoints in manually loaded/unloaded shlibs


Jeff Johnston <jjohnstn@redhat.com> wrote:
> The test should behave the same because the gdb code that generates
> the message it is checking hasn't been committed yet.  On retrospect,
> perhaps I should not have committed the testcase in with this
> particular check in place (the test itself is a valid one regardless).
> There has been some questions regarding whether I should be using an
> observer or not.  Knowing that, do I still need to do the following or
> can I check the change I attached in once I get final approval on the
> code and most importantly, the message to be issued?

I don't quite follow you, but if you are asking: can you check in
a change to the test script before you check in a change to gdb:
in general, you can do that.

If the test script accepts both old+new messages, and the new message is
not wildly more complex than the old message, then testing with the old
message alone is good enough for getting the test script approved.
Just pop out the new patch and say how / what system you tested on.

If that's not what you mean, I'm confused.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]