This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] Cleanup store.exp


Andrew Cagney <cagney@gnu.org> wrote:

This gets rid of the duplicate test messages in sore.exp.  Tested on FC2.
m'kay.


This patch is approved.

Committed (I hope).


I'm particularly happy with this bit:

  -    gdb_test "print l" " = ${l}" "print old l - ${t}"
  -    gdb_test "print r" " = ${r}" "print old r - ${t}"
  +    gdb_test "print l" " = ${l}" \
  +	"${prefix}; print old l, expecting ${l}"
  +    gdb_test "print r" " = ${r}" \
  +	"${prefix}; print old r, expecting ${r}"

Maybe it's just me, but when I saw "print old l - int",
I parsed it as "print old l minus int".  So I'm glad to see
the dash character go away.

Yea, `;' as a convention also works much better.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]