This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] function descriptor handling for push_dummy_call


> So they could all, as a mechanical operation, be changed from:
> 
>   ..._call (..., CORE_ADDR funaddr, ...)
> 
> to:
> 
>   ..._call (..., struct value *function, ...)
>   {
>     CORE_ADDR funaddr = find_function_addr (function);
> 
> (perhaphs make find_function_addr robust to a NULL value_type).

yes, except it's not used in most of the cases.... so i wasn't even
going to add the call, but i can "just to be safe"....

> I was thinking that infcall.c should convert "function" into a proper 
> function pointer but this appears just as effective.
> 
> I think this is ok.

ok, i will check in after i manage to go change all the targets and run
it through gdb_mbuild.sh..... probably next week.  i'll also update
gdbint.texinfo before i check in.

thanks,
randolph
-- 
Randolph Chung
Debian GNU/Linux Developer, hppa/ia64 ports
http://www.tausq.org/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]