This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[ob] Delete deprecated_frame_in_dummy, never called
- From: Andrew Cagney <cagney at gnu dot org>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 08 May 2004 14:48:02 -0400
- Subject: [ob] Delete deprecated_frame_in_dummy, never called
Remember DEPRECATED_USE_GENERIC_DUMMY_FRAMES is always one.
committed,
Andrew
2004-05-08 Andrew Cagney <cagney@redhat.com>
* breakpoint.h (deprecated_frame_in_dummy): Delete declaration.
(struct frame_info): Delete opaque declaration.
* breakpoint.c (deprecated_frame_in_dummy): Delete function.
* frame.c (get_frame_type): Delete call.
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.171
diff -p -u -r1.171 breakpoint.c
--- breakpoint.c 5 May 2004 21:18:10 -0000 1.171
+++ breakpoint.c 8 May 2004 18:44:52 -0000
@@ -1767,37 +1767,6 @@ software_breakpoint_inserted_here_p (COR
return 0;
}
-/* Return nonzero if FRAME is a dummy frame. We can't use
- DEPRECATED_PC_IN_CALL_DUMMY because figuring out the saved SP would
- take too much time, at least using frame_register() on the 68k.
- This means that for this function to work right a port must use the
- bp_call_dummy breakpoint. */
-
-int
-deprecated_frame_in_dummy (struct frame_info *frame)
-{
- struct breakpoint *b;
-
- /* This function is used by two files: get_frame_type(), after first
- checking that !DEPRECATED_USE_GENERIC_DUMMY_FRAMES; and
- sparc-tdep.c, which doesn't yet use generic dummy frames anyway. */
- gdb_assert (!DEPRECATED_USE_GENERIC_DUMMY_FRAMES);
-
- ALL_BREAKPOINTS (b)
- {
- if (b->type == bp_call_dummy
- && frame_id_eq (b->frame_id, get_frame_id (frame))
- /* We need to check the PC as well as the frame on the sparc,
- for signals.exp in the testsuite. */
- && (get_frame_pc (frame)
- >= (b->loc->address
- - DEPRECATED_SIZEOF_CALL_DUMMY_WORDS / sizeof (LONGEST) * DEPRECATED_REGISTER_SIZE))
- && get_frame_pc (frame) <= b->loc->address)
- return 1;
- }
- return 0;
-}
-
/* breakpoint_thread_match (PC, PTID) returns true if the breakpoint at
PC is valid for process/thread PTID. */
Index: breakpoint.h
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.h,v
retrieving revision 1.32
diff -p -u -r1.32 breakpoint.h
--- breakpoint.h 8 Apr 2004 21:18:12 -0000 1.32
+++ breakpoint.h 8 May 2004 18:44:52 -0000
@@ -619,13 +619,6 @@ extern int breakpoint_inserted_here_p (C
extern int software_breakpoint_inserted_here_p (CORE_ADDR);
-/* FIXME: cagney/2002-11-10: The current [generic] dummy-frame code
- implements a functional superset of this function. The only reason
- it hasn't been removed is because some architectures still don't
- use the new framework. Once they have been fixed, this can go. */
-struct frame_info;
-extern int deprecated_frame_in_dummy (struct frame_info *);
-
extern int breakpoint_thread_match (CORE_ADDR, ptid_t);
extern void until_break_command (char *, int, int);
Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.179
diff -p -u -r1.179 frame.c
--- frame.c 7 May 2004 23:19:14 -0000 1.179
+++ frame.c 8 May 2004 18:44:53 -0000
@@ -1983,12 +1983,6 @@ frame_relative_level (struct frame_info
enum frame_type
get_frame_type (struct frame_info *frame)
{
- /* Some targets still don't use [generic] dummy frames. Catch them
- here. */
- if (!DEPRECATED_USE_GENERIC_DUMMY_FRAMES
- && deprecated_frame_in_dummy (frame))
- return DUMMY_FRAME;
-
/* Some legacy code, e.g, mips_init_extra_frame_info() wants
to determine the frame's type prior to it being completely
initialized. Don't attempt to lazily initialize ->unwind for