Re: [RFA] Fix small problems in rs6000-tdep.c:skip_prologue()

[Jim Blandy <jimb at redhat dot com>]

Daniel Jacobowitz <drow@false.org> writes:
> On Fri, Apr 16, 2004 at 10:15:45PM -0700, Joel Brobecker wrote:
> > > In this case, the stX 0,N(31) is spilling an argument, even though r0
> > > is not an argument register.  ('evstdd' is an E500 instruction that
> > > is definitely an argument spill.)
> > 
> > Dough!
> > 
> > > Clearly, both your function and mine need to go into the test suite...
> > 
> > I can add a new testcase in Ada for the prologue we saw.
> 
> I'd prefer that you add them to gdb.asm, unless it's likely to produce
> strange prologues on other architectures.  That way you can test what
> you're trying to test, instead of something different.  For instance,
> once dwarf2 unwinding is switched on for PPC, an Ada testcase is likely
> to not trigger most of the prologue scanning.

I totally agree.  Prologue analysis failures are a major part of
stabilizing a GDB port, at least for me.  I've never actually dumped
the exact prologues I've got on hand into a test script, but it seems
like the obvious thing to do.  Is there some reason we don't already?