This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/testsuite] Fix expected output for "help set follow-fork-mode"
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at gnat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sun, 4 Apr 2004 17:12:41 -0400
- Subject: Re: [patch/testsuite] Fix expected output for "help set follow-fork-mode"
- References: <20040404203539.GG871@gnat.com>
On Sun, Apr 04, 2004 at 01:35:39PM -0700, Joel Brobecker wrote:
> There has been a recent change to infrun (made on 2004-01-13) that
> removed the choice "ask" to the possible values for "follow-fork-mode".
> The help text for that variable was then modified, but the test
> verifying that the help for this command exists has not been modified.
>
> This patch updates the expected output to match the new help text.
>
> 2004-04-04 Joel Brobecker <brobecker@gnat.com>
>
> * gdb.base/foll-fork.exp: Update the expected output for
> "help set follow-fork-mode", to match a change that was made
> to the help of this variable on 2004-01-13.
>
> Checked in as obvious.
Thanks. I keep meaning to fix up this test to run, when possible, on
GNU/Linux; but there's some trickiness involved and I've failed to do
it adequately a few times now.
>
> I don't really know the purpose of this test. If, as the comment
> suggests:
>
> # Verify that help is available for "set follow-fork-mode".
>
> Then I would recommend that we don't need to check for the entire
> help text word for word. I would simply check for the first line,
> or even maybe just check that we receive something, anything, before
> we get the prompt back.
I agree, personally.
> (BTW, Is it really necessary to use send_gdb + gdb_expect? Could gdb_test
> work just as well?)
Yes, feel free.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer