This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix compilation of tui/tui.c


Date: Sat, 28 Feb 2004 11:21:45 -0500
From: Andrew Cagney <cagney@gnu.org>


> Is there a reason for changing "" to <>, it breaks some of GDB's
> scripts.
> > I changed because we seem to use <> everywhere else in GDB for the
> readline includes, e.g. event-top.c, completer.c. I think it's good
> to be consistent; you get less surprises that way.


I'll change them so that they are consistent. gdb_makefile.sh: http://sources.redhat.com/gdb/current/ari/gdb_makefile.sh knows about "..." includes.


Andrew, how about saying this somewhere in the coding standards
description?  I, for one, was unaware of the special importance of
"...", and I presume Mark didn't know that as well.

Once there's a branch I intend going two (?) better, change the build process so that we don't need to worry about dependencies any more (but yes that will involve documentation).


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]