This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ob] Don't clobber inferior_ptid in read_pc_pid


On Sat, Feb 28, 2004 at 02:32:55PM -0500, Andrew Cagney wrote:

>Another issue found in testing on arm-linux.  A return was added to this
>function back in June; if we return from the middle of it, we leave
>inferior_ptid set to the wrong thread.  This causes a "!ptid_equal
>(ecs->ptid, inferior_ptid)" test to fail, since we called read_pc_pid
>with ecs->ptid.  That leads to not calling context_switch; which clobbers
>the stepping range for the previous thread; which causes stepping to stop
>unexpectedly.
>
>I'll commit this patch as obvious in a day or two.

It isn't obvious, but it does appear to be correct.


Can you please commit it now?


Sorry, I had left before this message arrived.

My goal in waiting was to retest on another target, which I did not
have time for this morning, and to wait for the release branch to be
confusion on my own part about the timing, since as of your
next-to-last announcement you were planning on back-dating the release
branch.  These are patches I consider suitable for the release branch
and it's not much extra work for me to retest and commit them on two
branches.

When I check in patches immediately people complain that I am acting
impetuously.  When I wait you ask me to commit the patch now.  When I
get back and see your message I get:

My post clearly has context - if that change were committed before the branch was cut, life will be easy for all concerned.


It doesn't say commit to an un-announced branch the moment you see the first hint that it is being created. That will make the release engineer's life hell.

I'm going to alter the releng notes to point out that the first mention of the branch should be its announcement. That hopefully will stop future occurances of this problem.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]