This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] v2 bigcore.exp


On Mon, Feb 16, 2004 at 01:54:55PM -0500, Andrew Cagney wrote:
> >Andrew Cagney <cagney@gnu.org> writes:
> >
> >
> >>+  /* Compute an initial chunk size.  The math is dodgy but it works
> >>+     for the moment.  Perhaphs there's a constant around somewhere.  */
> >>+  {
> >>+    size_t tmp;
> >>+    for (tmp = 1; tmp > 0; tmp <<= 1)
> >>+      max_chunk_size = tmp;
> >
> >
> >max_chunk_size = ~((size_t) -1 >> 1);
> 
> What's to stop the right shift smearing the sign bit?
> 
> (I've just checked in the current test, we can fix this once we know a 
> better equation).

Size_t is guaranteed to be unsigned, so it can't, afaict.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]