This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] sh-tdep.c: Define only the minimal register set in sh_generic_register_name


Corinna Vinschen writes:
 > Hi,
 > 
 > while looking into the sh_generic_register_name function, I began to wonder
 > why that function defines a register set, which is not exactly generic,
 > but instead gives a name to all 59 register entries.  Many of them are
 > only correct on CPUs with FPU and/or register banks. 
 > 
 > IMHO, the generic_name function should only define the maximum common
 > register set, which is the same as the one for the basic sh CPU variant.
 > 
 > Therefore I'd like to propose the following patch, which does exactly
 > that.  An alternative approach would be, to remove the
 > sh_generic_register_name entirely and use sh_sh_register_name instead.
 > 

Your are right. I would prefer to just get rid of the function
entirely.  It is already the same as the sh3e_register_name. And after
the change it would duplicate the sh_register_name. No point in
keeping it around.

elena


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]