This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Partial infcmd.c cleanup


But I didn't.  It already was static, since the earlier on in the file
we have the prototype:

static void finish_command_continuation (struct continuation_arg *);

I should have mentioned it in the ChangeLog.

Sigh, "GDB's K&R herritage hits, you start feeling old" :-) The code style:


static void func (args);

... big big gap ...

	void
	func (args)
	{
	  ..
	}

dates back to K&R C days where we ended up with:

	static void func PARAMS ((type arg, ...));
	... big big gap ...
	void
	func (arg)
	   type arg;
	{
	}

to ensure that prototypes were present. With the switch to ISO-C those declarations became entirely reundant (except when a forward declaration is explicitly needed) and have since been slowly disappearing.

enjoy,
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]