This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Ping - PR1473
On Wed, Jan 21, 2004 at 04:12:24PM +0000, Paul Brook wrote:
> On Monday 05 January 2004 9:06 pm, Daniel Jacobowitz wrote:
> > I don't like the idea of adding this test to keep_going. This should
> > only be necessary in the BPSTAT_WHAT_CHECK_SHLIBS case, correct?
>
> Yes.
>
> > Something like this:
> >
> > - if (stop_on_solib_events)
> > + if (stop_on_solib_events || stop_stack_dummy)
>
> Updated patch appended below, ok to apply?
> Tested on i686-linux.
>
> > I don't know if you need a stop_print_frame=0 also if
> > (stop_stack_dummy).
>
> This is already handled elsewhere.
>
> Paul
>
> 2004-01-21 Paul Brook <paul@codesourcery.com>
>
> * infrun.c (handle_inferior_event): Check stop_stack_dummy if handling
> BPSTAT_CHECK_WHAT_SHLIBS.
Typo, it's BPSTAT_WHAT_CHECK_SHLIBS I think.
This patch is OK. Please also add yourself to write-after-approval in
gdb/MAINTAINERS, and post the patch and changelog for that.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer