This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfc] Give decr pc after break a default of zero
- From: Mark Kettenis <kettenis at chello dot nl>
- To: cagney at gnu dot org
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 16 Jan 2004 17:23:54 +0100 (CET)
- Subject: Re: [patch/rfc] Give decr pc after break a default of zero
- References: <40071B7A.3080106@gnu.org>
Date: Thu, 15 Jan 2004 18:00:10 -0500
From: Andrew Cagney <cagney@gnu.org>
Almost all architectures are setting DECR_PC_AFTER_BREAK to zero, this
makes that value the default.
Yeah!
The main exception is i386, and even that has an exception to the
exception - Neutrino. For Neutrino I've left the set-to-zero as is so
that it's clear that it is overriding the i386.
Removing the set-to-zero for Neutrino would be wrong; it is essential
that we override the i386 default. Personally I think the "NOTE" form
of the comment you added isn't really appropriate. I'd prefer
something like:
/* Neutrino rewinds to look more normal, so we have to override the
i386 default value. */
Since that explains why we override the i386 default value. It's
probably a matter of taste, but I'd appreciate if you changes it that
way.
Mark