This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA]: Fix do_cleanups if oldchain is NULL


On Mon, Jan 05, 2004 at 10:32:38AM -0500, Andrew Cagney wrote:
> >
> >How about making NULL an internal error then, as below?  I think we
> >should either do that or document its behavior, and it seems
> >accident-prone.
> 
> I thought about that, and would likely be ok if there were only normal 
> simple cleanups.  Its the "other" (i.e., final, run, exec, ...) cleanups 
> that trouble me.

Right you are, infcmd.c:run_command:
   do_run_cleanups (NULL);

We could put the internal error in do_cleanups instead, but I'm not
sure that it's worthwhile.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]