This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Prune some deadwood in dwarf2read.c:decode_locdesc
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Tue, 18 Nov 2003 16:52:22 -0500
- Subject: Re: [PATCH] Prune some deadwood in dwarf2read.c:decode_locdesc
- References: <20031117041950.GA22322@nevyn.them.org>
On Sun, Nov 16, 2003 at 11:19:50PM -0500, Daniel Jacobowitz wrote:
> This patch is obvious; barring comments I'll commit it in a day or two.
> Neither of these flags is checked any more now that LOC_COMPUTED is used.
>
> The current status quo, by the way, is that there is one caller of
> decode_locdesc left which checks these global flags. I believe that that
> call (for DW_AT_frame_base) is entirely dead and can be removed, after which
> it will be possible to simplify decode_locdesc even further. But it's
> slightly less trivially dead, so I'll do that in a separate patch when I'm
> more awake.
>
> After that, decode_locdesc will only ever be used in places where we expect
> a constant result - a global variable, a structure offset, et cetera.
> Everything else has been converted to LOC_COMPUTED and LOC_COMPUTED_ARG.
>
> --
> Daniel Jacobowitz
> MontaVista Software Debian GNU/Linux Developer
>
> 2003-11-16 Daniel Jacobowitz <drow@mvista.com>
>
> * dwarf2read.c (optimized_out, islocal): Remove.
> (decode_locdesc): Update comments. Don't set optimized_out
> or islocal.
Checked in.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer