This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa:symtab] SYMBOL_LOCATION_FUNCS -> SYMBOL_OPS



FWIW, this patch looks good to me.  I only have two questions.  One is
with the generalized name - do you expect anything besides the location
(the aclass really is a part of the location, I think) to be handled by
these ops?  I'm not sure what else there is, so it's just an idle
thought.

Other methods that play with the union come to mind.


And, I think I see where you're going with the index idea, but since it
wasn't obvious until the second time through: the index could take up
to ten bits, replacing the address class, and thereby eliminating the
ops pointer.  That's where the 32 bits comes from, not from eliminating
aclass.  This costs a table lookup every time you want to get at the
aclass or ops, but that's probably OK.

Yes. Doing a location extraction isn't on a hot path.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]