This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa:symtab] deprecate inside_entry_func


On Fri, Oct 31, 2003 at 07:07:28PM -0500, Andrew Cagney wrote:

Hello,

This patch deprecates the function inside_entry_func. Per the new comments:

+  /* NOTE: cagney/2003-10-31: A very simple test, such as
+     get_frame_func == entry_point should be sufficient for
+     identifying a pc in the entry function.  Does anyone know why it
+     wasn't sufficient and hence, why the very convoluted
+     "deprecated_inside_entry_func" is needed.  */
+  /* NOTE: cagney/2003-10-31: An ABI and its crt0 code should define
+     and implement a clean frame termination.  Not doing that is
+     really a bug in the ABI/crt0, and, hence, not a reason for
+     enabling the call to deprecated_inside_entry_func.  */


If handling broken systems isn't the job of GDB, then I surely don't
know what is.
Do you have a reason for wanting to deprecate this function?

Per my first new comment:


/* NOTE: cagney/2003-10-31: A very simple test, such as
   get_frame_func == entry_point should be sufficient for
   identifying a pc in the entry function.  Does anyone know why it
   wasn't sufficient and hence, why the very convoluted
   "deprecated_inside_entry_func" is needed.  */

and the previous comment:

  /* NOTE: cagney/2003-02-25: Don't enable until someone has found
     hard evidence that this is needed.  */

There is _still_ no evidence that this disabled hack is needed - time to deprecate it.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]