This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit] target_open (target, ...)
On Wed, Oct 22, 2003 at 10:55:25PM -0400, Andrew Cagney wrote:
>
> >Wrong patch? This is target_close, not target_open. It also deletes
> >the target_open macro without adding a new target_open function.
>
> No, a 180 description. s/target_open/target_close/. The _macro_
> target_open() is _never_ called.
Gotcha.
> >Please don't add 'x'. There's nothing wrong with having a target_open
> >function which calls target_ops->to_open.
>
> The vector already contains ->to_open and ->to_close methods so unless
> we've switched to C++, I can't add a second to_close.
>
> Once the existing ->to_close is deprecated, I can rename ->to_xclose.
OK. It'd be nice if you'd explain that sort of thing when posting the
patch, though.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer