This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA/RFC] Replecament for DEPRECATED_REG_STRUCT_HAS_ADDR


Here is the promised patch to replace DEPRECATED_REG_STRUCT_HAS_ADDR.
I've baptized the new method stabs_argument_has_addr since that better

like it.


describes what it does than the old REG_STRUCT_HAS_ADDR; it's also
used for non-register and non-struct arguments, at least on SPARC.  I
also dropped the gcc_p argument since none of the current
implementations of DEPRECATED_REG_STRUCT_HAS_ADDR actually use it.

Anyway, I moved the type checks that were done in stabsread.c into
default_stabs_argument_has_addr.  This means that
stabs_argument_has_addr has to do all type-checks.  On SPARC this is
needed to support quad-precision floating-point arguments.

Andrew, I made stabs_argument_has_addr a multi-arch function, and I
don't provide a macro for it.  Is that all-right?  I'm a bit confused
when to provide a macro and when not.  What are your current ideas
about that?  Personally I think we should get rid of the macros and
explicitly use current_gdbarch.

Yep, thats the intent.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]