This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: trivial PATCH to dwarf2read.c:dwarf_attr_name


On Wed, Aug 27, 2003 at 10:46:42AM -0400, Andrew Cagney wrote:
> >On Tue, 26 Aug 2003 23:56:42 -0400, Andrew Cagney <ac131313@redhat.com> 
> >wrote:
> >
> >
> >>>I'm checking this in under the obvious rule; DW_AT_MIPS_linkage_name is
> >>>used on all targets.
> >>>2003-08-26  Jason Merrill  <jason@redhat.com>
> >>>	* dwarf2read.c (dwarf_attr_name): Move DW_AT_MIPS_linkage_name
> >>>	case out of #ifdef MIPS block.
> >>>
> >
> >>
> >>Jason, exactly what prompted the change?  In particular which GCC?
> >
> >
> >I don't remember.  I think it's been in my local tree for years.  It's
> >quite likely that I just noticed it.
> 
> Can you please find out.  There must be a stronger rationale then "it's 
> been in my local tree for years".

Well, the patch is certainly right.  GCC generates
DW_AT_MIPS_linkage_name on all targets, and has for as far back as I
have GCC sources to check it.

We just don't use dwarf_attr_name much, so it didn't matter.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]