This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: GDB bug report 1334 fix
- From: Michael Snyder <msnyder at redhat dot com>
- To: "Newman, Mark (N-Superior Technical Resource Inc)" <mark dot newman at lmco dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 21 Aug 2003 11:12:38 -0700
- Subject: Re: GDB bug report 1334 fix
- Organization: Red Hat, Inc.
- References: <F56FBA314E8E5A41895F0DA8F6716A6D02A417@EMSS04M11.us.lmco.com>
Newman, Mark (N-Superior Technical Resource Inc) wrote:
A problem using tstart on an I86 Linux box. (Actaully this is probably
an across the board problem)
-----Original Message-----
As a better description:
in tracepoint.c routine set_traceframe_context
first time set:
set_internalvar (lookup_internalvar ("trace_line"),
value_from_pointer (builtin_type_int, (LONGEST) -
1));
next time set
set_internalvar (lookup_internalvar ("trace_line"),
value_from_longest (builtin_type_int,
(LONGEST) traceframe_sal.line));
I changed the first instance to:
set_internalvar (lookup_internalvar ("trace_line"),
value_from_longest (builtin_type_int, (LONGEST) -
1));
This seems to stop the error detection in findvar from griping.
Thanks; I've committed your suggested fix, as follows:
2003-08-21 Michael Snyder <msnyder@redhat.com>
* tracepoint.c (set_traceframe_context): Make "trace_line" an int.
Fix suggested by Mark Newman <mark.newman@lmco.com>
Index: tracepoint.c
===================================================================
RCS file: /cvs/src/src/gdb/tracepoint.c,v
retrieving revision 1.51
retrieving revision 1.52
diff -p -r1.51 -r1.52
*** tracepoint.c 11 Jun 2003 23:29:48 -0000 1.51
--- tracepoint.c 21 Aug 2003 18:09:54 -0000 1.52
*************** set_traceframe_context (CORE_ADDR trace_
*** 266,272 ****
set_internalvar (lookup_internalvar ("trace_file"),
value_from_pointer (charstar, (LONGEST) 0));
set_internalvar (lookup_internalvar ("trace_line"),
! value_from_pointer (builtin_type_int, (LONGEST) - 1));
return;
}
--- 266,272 ----
set_internalvar (lookup_internalvar ("trace_file"),
value_from_pointer (charstar, (LONGEST) 0));
set_internalvar (lookup_internalvar ("trace_line"),
! value_from_longest (builtin_type_int, (LONGEST) - 1));
return;
}