This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] space reduction in gdbtypes.h


Hi Jim,

jimb> - I think it's important that this struct start with something that
jimb>   indicates which sort of type it represents.  It's weird to have the
jimb>   discriminant buried in the middle.  So leave 'code' the first member
jimb>   of the structure, and move the {upper,lower}_bound_type fields up.
jimb> - Add a short comment indicating that the {upper,lower}_bound_type
jimb>   fields pack better at that location.

Okay, I will do that, and re-test, and then commit.

I thought about trying the __packed__ attribute but I am allergic to
__packed__ because I've seen that word in too many bug reports.  My gut
feeling is that hand layout is safer.

This is the last of the "easy re-arrangement" patches.  Next I will
write an essay about the minsyms 'info' pointer, which really bites,
and submit some cleanup patches for that.

Michael C


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]