This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Re: Analyzing AMD64 corefiles on i386
Date: Wed, 9 Jul 2003 14:08:01 -0400
From: Daniel Jacobowitz <drow@mvista.com>
> Not as such. We can't allow public functions with the names
> supply_gregset and fill_gregset in *-tdep.c files. Therefore these
> functions should be renamed, and supply_gregset and fill_gregset
> should be kept in your *-nat.c file. You'll probably want to rewrite
> those functions such that they call the new functions in *-tdep.c.
I don't see the harm. They need to be multi-arched instead of called
by name, eventually, but it's no extra work to rename them at that
time.
Not renaming them makes it impossible to build an i386 native GDB that
can also debug amd64.
> Personally I wouldn't define all those constants if the only place
> where they'll be used is the regmap array, but that's a matter of
> taste.
I'm guessing it makes it easier to at-a-glance compare with
<sys/reg.h>. I did the same thing.
That's a valid reason. Probably deserves a comment such that nobody
gratuitously re-orders the defines.
Mark