This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [Patch 2] Native QNX Neutrino support
- From: Mark Kettenis <kettenis at chello dot nl>
- To: kewarken at qnx dot com
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 4 Jul 2003 13:55:26 +0200 (CEST)
- Subject: Re: [Patch 2] Native QNX Neutrino support
- References: <001a01c3261c$313284c0$0202040a@catdog> <86ptlfh67k.fsf@elgar.kettenis.dyndns.org> <06ad01c3342d$c4039e50$0202040a@catdog>
I finally found the time to review your "take 2".
* Use xstrdup() instead of strdup().
* The function calls in the definitions of the QNX_NODE macro need
spaces before the '(' just like in normal functions. Could you turn
this macro into a function?
* While what Andrew says about not having an XM_FILE is desirable, I
think we still need xm-i386.h to have the best possible handling of
floating-point numbers on a native GDB. If you don't set it,
unnecessary conversions of floating-point numbers might occur,
leading to loss of precision. I'll leave the decision to you.
With those changes, please go ahead and check it in.
Mark