This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: question about commits


Hi,

I've got the avr port down to one more patch to get it frame-ified,
but the diff is a bit messy (diff doesn't handle simultaneous removal
and insertion of code very well).

Looking at the other architectures, a single commit with a full changelog, has become accepted as the norm. It really is a s/old/new/ so there isn't much else that can be done.


Andrew


If I split it into two diffs, first one which performs the wholesale
removal of code to be replaced and the second which adds the new
replacement code, if becomes much easier to look at the diffs and see
exactly what was changed.

So, is it acceptable to commit the changes in this way? If so, show I
also note the 2 part nature in the commit log/ChangeLog entries?



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]