Re: [patch rfc] Eliminate deprecated_generic_get_saved_regs()

[Andrew Cagney <ac131313 at redhat dot com>]

> Hello,
>
> This patch does two things:
> - renames the recursive generic_unwind_get_saved_regs to deprecated_get_saved_regs
> - replaces any occurance of deprecated_generic_get_saved_regs with the recursive equivalent deprecated_get_saved_regs
> The main objective here is to clean out one bit of the old get_saved_regs code.  Plenty more to go though.

On second thoughts, I committed the attached.  Much simpler, but the 
same effect.

> 2003-06-01  Andrew Cagney  <cagney@redhat.com>
>
> 	* frame.h (deprecated_get_saved_register): Declare.
> 	(generic_unwind_get_saved_register): Delete declaration.
> 	(deprecated_generic_get_saved_register): Delete declaration.
> 	* frame.c (deprecated_get_saved_register): Rename
> 	generic_unwind_get_saved_register.
> 	(deprecated_generic_get_saved_register): Delete function.
> 	* sh-tdep.c (sh_gdbarch_init): Set deprecated_get_saved_register
> 	to deprecated_get_saved_register.
> 	* m68hc11-tdep.c (m68hc11_gdbarch_init): Ditto.
> 	* cris-tdep.c (cris_gdbarch_init): Ditto.
> 	* xstormy16-tdep.c (xstormy16_get_saved_register): Use
> 	deprecated_get_saved_register.
> 	(xstormy16_frame_saved_register): Ditto.
> 	* mips-tdep.c (mips_get_saved_register): Ditto.
> 	* ia64-tdep.c (ia64_get_saved_register): Ditto.

Andrew

2003-06-09  Andrew Cagney  <cagney@redhat.com>

	* frame.h (deprecated_unwind_get_saved_register): Rename
	generic_unwind_get_saved_register, update comments.
	* mips-tdep.c (mips_get_saved_register): Update.
	* frame.c (deprecated_unwind_get_saved_register): Update.

Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.120
diff -u -r1.120 frame.c
--- frame.c	9 Jun 2003 02:10:34 -0000	1.120
+++ frame.c	9 Jun 2003 22:19:14 -0000
@@ -674,12 +674,12 @@
 }
 
 void
-generic_unwind_get_saved_register (char *raw_buffer,
-				   int *optimizedp,
-				   CORE_ADDR *addrp,
-				   struct frame_info *frame,
-				   int regnum,
-				   enum lval_type *lvalp)
+deprecated_unwind_get_saved_register (char *raw_buffer,
+				      int *optimizedp,
+				      CORE_ADDR *addrp,
+				      struct frame_info *frame,
+				      int regnum,
+				      enum lval_type *lvalp)
 {
   int optimizedx;
   CORE_ADDR addrx;
Index: frame.h
===================================================================
RCS file: /cvs/src/src/gdb/frame.h,v
retrieving revision 1.98
diff -u -r1.98 frame.h
--- frame.h	9 Jun 2003 15:20:21 -0000	1.98
+++ frame.h	9 Jun 2003 22:19:15 -0000
@@ -492,19 +492,16 @@
 
 extern char *deprecated_generic_find_dummy_frame (CORE_ADDR pc, CORE_ADDR fp);
 
-void generic_unwind_get_saved_register (char *raw_buffer,
-				        int *optimizedp,
-				        CORE_ADDR *addrp,
-				        struct frame_info *frame,
-				        int regnum,
-				        enum lval_type *lvalp);
 
-/* The function generic_get_saved_register() has been made obsolete.
-   DEPRECATED_GET_SAVED_REGISTER now defaults to the recursive
-   equivalent - generic_unwind_get_saved_register() - so there is no
-   need to even set DEPRECATED_GET_SAVED_REGISTER.  Architectures that
-   need to override the register unwind mechanism should modify
-   frame->unwind().  */
+/* The DEPRECATED_GET_SAVED_REGISTER architecture interface is
+   entirely redundant.  New architectures should implement per-frame
+   unwinders (ref "frame-unwind.h").  */
+extern void deprecated_unwind_get_saved_register (char *raw_buffer,
+						  int *optimizedp,
+						  CORE_ADDR *addrp,
+						  struct frame_info *frame,
+						  int regnum,
+						  enum lval_type *lvalp);
 extern void deprecated_generic_get_saved_register (char *, int *, CORE_ADDR *,
 						   struct frame_info *, int,
 						   enum lval_type *);
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.208
diff -u -r1.208 mips-tdep.c
--- mips-tdep.c	9 Jun 2003 17:35:58 -0000	1.208
+++ mips-tdep.c	9 Jun 2003 22:19:16 -0000
@@ -5453,8 +5453,8 @@
     lvalp = &lvalx;
   if (optimizedp == NULL)
     optimizedp = &optimizedx;
-  generic_unwind_get_saved_register (raw_buffer, optimizedp, addrp, frame,
-                                     regnum, lvalp);
+  deprecated_unwind_get_saved_register (raw_buffer, optimizedp, addrp, frame,
+					regnum, lvalp);
   /* FIXME: cagney/2002-09-13: This is just so bad.  The MIPS should
      have a pseudo register range that correspons to the ABI's, rather
      than the ISA's, view of registers.  These registers would then