This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[commit] Don't set frame_{args,local}_address to the default
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Mon, 09 Jun 2003 16:11:29 -0400
- Subject: [commit] Don't set frame_{args,local}_address to the default
Hello,
Simple cleanup. No sense in re-setting the per-architecture
frame_args_address / frame_locals_address to the default value (return
get_frame_base). This patch deletes all the cases where that was occuring.
committed,
Andrew
2003-06-09 Andrew Cagney <cagney@redhat.com>
* vax-tdep.c (vax_frame_locals_address): Delete function.
(vax_gdbarch_init): Do not set frame_locals_address.
* m68hc11-tdep.c (m68hc11_frame_locals_address): Delete function.
(m68hc11_gdbarch_init): Do not set frame_locals_address.
* s390-tdep.c (s390_frame_args_address): Delete function.
(s390_gdbarch_init): Do not set frame_args_address or
frame_locals_address.
* ns32k-tdep.c (ns32k_frame_locals_address): Delete.
(ns32k_gdbarch_init): Do not set frame_locals_address.
* hppa-tdep.c (hppa_frame_args_address): Delete function.
(hppa_frame_locals_address): Delete function.
(hppa_gdbarch_init): Do not set frame_args_address, or
frame_locals_address.
* arm-tdep.c (arm_frame_args_address): Delete.
(arm_frame_locals_address): Delete.
(arm_gdbarch_init): Do not set frame_args_address, or
frame_locals_address.
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.138
diff -u -r1.138 arm-tdep.c
--- arm-tdep.c 9 Jun 2003 17:35:56 -0000 1.138
+++ arm-tdep.c 9 Jun 2003 20:04:14 -0000
@@ -306,20 +306,6 @@
return frameless;
}
-/* The address of the arguments in the frame. */
-static CORE_ADDR
-arm_frame_args_address (struct frame_info *fi)
-{
- return get_frame_base (fi);
-}
-
-/* The address of the local variables in the frame. */
-static CORE_ADDR
-arm_frame_locals_address (struct frame_info *fi)
-{
- return get_frame_base (fi);
-}
-
/* A typical Thumb prologue looks like this:
push {r7, lr}
add sp, sp, #-28
@@ -2936,8 +2922,6 @@
set_gdbarch_frameless_function_invocation
(gdbarch, arm_frameless_function_invocation);
set_gdbarch_deprecated_frame_saved_pc (gdbarch, arm_frame_saved_pc);
- set_gdbarch_frame_args_address (gdbarch, arm_frame_args_address);
- set_gdbarch_frame_locals_address (gdbarch, arm_frame_locals_address);
set_gdbarch_frame_args_skip (gdbarch, 0);
set_gdbarch_deprecated_frame_init_saved_regs (gdbarch, arm_frame_init_saved_regs);
set_gdbarch_deprecated_pop_frame (gdbarch, arm_pop_frame);
Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.82
diff -u -r1.82 hppa-tdep.c
--- hppa-tdep.c 9 Jun 2003 17:35:57 -0000 1.82
+++ hppa-tdep.c 9 Jun 2003 20:04:15 -0000
@@ -4875,18 +4875,6 @@
}
CORE_ADDR
-hppa_frame_args_address (struct frame_info *fi)
-{
- return get_frame_base (fi);
-}
-
-CORE_ADDR
-hppa_frame_locals_address (struct frame_info *fi)
-{
- return get_frame_base (fi);
-}
-
-CORE_ADDR
hppa_smash_text_address (CORE_ADDR addr)
{
/* The low two bits of the PC on the PA contain the privilege level.
@@ -4972,8 +4960,6 @@
set_gdbarch_frameless_function_invocation
(gdbarch, hppa_frameless_function_invocation);
set_gdbarch_deprecated_frame_saved_pc (gdbarch, hppa_frame_saved_pc);
- set_gdbarch_frame_args_address (gdbarch, hppa_frame_args_address);
- set_gdbarch_frame_locals_address (gdbarch, hppa_frame_locals_address);
set_gdbarch_frame_args_skip (gdbarch, 0);
set_gdbarch_deprecated_push_dummy_frame (gdbarch, hppa_push_dummy_frame);
set_gdbarch_deprecated_pop_frame (gdbarch, hppa_pop_frame);
Index: m68hc11-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68hc11-tdep.c,v
retrieving revision 1.73
diff -u -r1.73 m68hc11-tdep.c
--- m68hc11-tdep.c 9 Jun 2003 17:35:57 -0000 1.73
+++ m68hc11-tdep.c 9 Jun 2003 20:04:15 -0000
@@ -419,12 +419,6 @@
return addr;
}
-static CORE_ADDR
-m68hc11_frame_locals_address (struct frame_info *frame)
-{
- return get_frame_base (frame);
-}
-
/* Discard from the stack the innermost frame, restoring all saved
registers. */
@@ -1393,7 +1387,6 @@
set_gdbarch_deprecated_frame_chain (gdbarch, m68hc11_frame_chain);
set_gdbarch_deprecated_frame_saved_pc (gdbarch, m68hc11_frame_saved_pc);
set_gdbarch_frame_args_address (gdbarch, m68hc11_frame_args_address);
- set_gdbarch_frame_locals_address (gdbarch, m68hc11_frame_locals_address);
set_gdbarch_deprecated_saved_pc_after_call (gdbarch, m68hc11_saved_pc_after_call);
set_gdbarch_deprecated_get_saved_register (gdbarch, deprecated_generic_get_saved_register);
Index: ns32k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ns32k-tdep.c,v
retrieving revision 1.50
diff -u -r1.50 ns32k-tdep.c
--- ns32k-tdep.c 7 Jun 2003 22:38:55 -0000 1.50
+++ ns32k-tdep.c 9 Jun 2003 20:04:16 -0000
@@ -357,12 +357,6 @@
return (read_register (SP_REGNUM) - 4);
}
-static CORE_ADDR
-ns32k_frame_locals_address (struct frame_info *frame)
-{
- return (get_frame_base (frame));
-}
-
/* Code to initialize the addresses of the saved registers of frame described
by FRAME_INFO. This includes special registers such as pc and fp saved in
special ways in the stack frame. sp is even more special: the address we
@@ -576,7 +570,6 @@
set_gdbarch_deprecated_frame_saved_pc (gdbarch, ns32k_frame_saved_pc);
set_gdbarch_frame_args_address (gdbarch, ns32k_frame_args_address);
- set_gdbarch_frame_locals_address (gdbarch, ns32k_frame_locals_address);
set_gdbarch_deprecated_frame_init_saved_regs (gdbarch, ns32k_frame_init_saved_regs);
Index: s390-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/s390-tdep.c,v
retrieving revision 1.100
diff -u -r1.100 s390-tdep.c
--- s390-tdep.c 9 Jun 2003 17:35:58 -0000 1.100
+++ s390-tdep.c 9 Jun 2003 20:04:16 -0000
@@ -941,15 +941,6 @@
-CORE_ADDR
-s390_frame_args_address (struct frame_info *fi)
-{
-
- /* Apparently gdb already knows gdb_args_offset itself */
- return get_frame_base (fi);
-}
-
-
static CORE_ADDR
s390_frame_saved_pc_nofix (struct frame_info *fi)
{
@@ -1816,10 +1807,8 @@
set_gdbarch_char_signed (gdbarch, 0);
set_gdbarch_frame_args_skip (gdbarch, 0);
- set_gdbarch_frame_args_address (gdbarch, s390_frame_args_address);
set_gdbarch_deprecated_frame_chain (gdbarch, s390_frame_chain);
set_gdbarch_deprecated_frame_init_saved_regs (gdbarch, s390_frame_init_saved_regs);
- set_gdbarch_frame_locals_address (gdbarch, s390_frame_args_address);
set_gdbarch_deprecated_store_struct_return (gdbarch, s390_store_struct_return);
set_gdbarch_deprecated_extract_return_value (gdbarch, s390_extract_return_value);
set_gdbarch_deprecated_store_return_value (gdbarch, s390_store_return_value);
Index: vax-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/vax-tdep.c,v
retrieving revision 1.54
diff -u -r1.54 vax-tdep.c
--- vax-tdep.c 9 Jun 2003 03:21:07 -0000 1.54
+++ vax-tdep.c 9 Jun 2003 20:04:16 -0000
@@ -182,12 +182,6 @@
return 0;
}
-static CORE_ADDR
-vax_frame_locals_address (struct frame_info *frame)
-{
- return (get_frame_base (frame));
-}
-
static int
vax_frame_num_args (struct frame_info *fi)
{
@@ -391,7 +385,6 @@
set_gdbarch_deprecated_frame_saved_pc (gdbarch, vax_frame_saved_pc);
set_gdbarch_frame_args_address (gdbarch, vax_frame_args_address);
- set_gdbarch_frame_locals_address (gdbarch, vax_frame_locals_address);
set_gdbarch_deprecated_frame_init_saved_regs (gdbarch, vax_frame_init_saved_regs);