Re: [RFA/testsuite] test hand function call in commands list

[Joel Brobecker <brobecker at gnat dot com>]

> I can reproduce this.  It's even simpler; we aren't executing the
> commands list even if if there's no inferior function call in them. 
> This appears to be specific to commands on a breakpoint hit during an
> inferior function call.
> 
> Did this ever work?  It looks like the call to error() when we stop in
> call_function_by_hand drops us out in start_event_loop, but the call to
> bpstat_do_actions is in command_handler (closer to the innermost end of
> the call chain, and thus bypassed by the error()).
> 
> Should we be calling bpstat_do_actions before that error()?

I had a quick look: This ``feature'' is present since at least 5.1.1
(I tried on Linux with 5.1.1, 5.2.1 and 5.3 - could not try with 5.0
as it had a problem reading DWARF2_FORM_strp). I don't know how Klee
got it to work.

Here is what I suggest: This issue is orthogonal to what we are trying
to test, so let's write a new test for it that does not rely on inferior
function calls to hit the breakpoints. We can also discuss whether we
consider this feature to be a bug or not.

What do you think?
-- 
Joel