Re: [RFA/PATCH] Behavior of gdb with -fullname and -interpreter=mi

[Elena Zannoni <ezannoni at redhat dot com>]

Dennis Brueni writes:
 > 
 > 2002-12-10  Dennis Brueni <dennis at slickedit dot com>
 > 
 > 	* stack.c: honor -fullname option when printing stack dump


[really really old patch]

It never occurred to me that one would want to use the annotate
interface together with the MI one. I don't think they were designed
to work together, as a matter of fact MI's purpose was to replace
annotate. What is the exact problem? Is the MI not informative enough
for your purposes? 

If --fullname only is used, the full path is printed by
annotate_source already.

If --fullname and MI are both used, MI will take over (I think).

If no --fullname (whether in MI mode or not), there is no output from
annotate_source and the relative path is printed.

What I think you are getting at (I think) is whether the MI output
should include fullpaths as well, which has been discussed on
gdb at sources dot redhat dot com dot 

elena


 > 
 > Index: stack.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/stack.c,v
 > retrieving revision 1.58
 > diff -c -p -b -r1.58 stack.c
 > *** stack.c	9 Dec 2002 03:30:44 -0000	1.58
 > --- stack.c	10 Dec 2002 20:03:26 -0000
 > *************** print_frame (struct frame_info *fi,
 > *** 553,559 ****
 > --- 553,563 ----
 >          ui_out_wrap_hint (uiout, "   ");
 >          ui_out_text (uiout, " at ");
 >          annotate_frame_source_file ();
 > +       if (annotation_level >= 1) {
 > +          ui_out_field_string (uiout, "file", symtab_to_filename(sal.symtab));
 > +       } else {
 >             ui_out_field_string (uiout, "file", sal.symtab->filename);
 > +       }
 >          annotate_frame_source_file_end ();
 >          ui_out_text (uiout, ":");
 >          annotate_frame_source_line ();
 > 
 > 
 > ===================================================================
 > 
 > Problem:
 > 
 >      When using gdb with -interpreter=mi and the -fullname option,
 >      the stack dumps still show file names using relative paths
 >      rather than the fully qualified path you would expect.
 >  
 >      When in MI mode, the annotations that would normally show the
 >      fully qualified path are not produced.
 > 
 > Description:
 > 
 >      The fix simply attempts to find the fully qualified path to
 >      the source file if -fullname is given, independent of the
 >      interpreter mode.  This works perfectly for the MI mode, and
 >      I think it is fair to argue that it should be the expected
 >      behavior for all other modes as well.
 > 
 > Fix Description:
 > 
 >      Four line modification to stack.c in the print_frame() function.
 > 
 > Notes:
 > 
 >      The modification makes -fullname do what I expect it to do, however,
 >      I do acknowledge that existing software that controls GDB, for example,
 >      emacs, may expect only the annotations to be fully qualified.  So this
 >      change may break those programs.
 > 
 >      In the -interpreter=mi case, since the annotations are not produced,
 >      I believe that, without this patch, -fullname is broken.
 > 
 >      Given my druthers, I would rather see -fullname behave consistently
 >      rather than working in one mode and not in another.
 > 
 >      If this fix is accepted, it would be great if it made the 5.4 release.
 > 
 > 
 > Examples [before]:
 > 
 >      [dbrueni at falcon gdb]$ ./gdb -fullname ./gdb
 >      GNU gdb 2002-12-10-cvs
 >      Copyright 2002 Free Software Foundation, Inc.
 >      GDB is free software, covered by the GNU General Public License, and you are
 >      welcome to change it and/or distribute copies of it under certain conditions.
 >      Type "show copying" to see the conditions.
 >      There is absolutely no warranty for GDB.  Type "show warranty" for details.
 >      This GDB was configured as "i686-pc-linux-gnu"...
 >      Setting up the environment for debugging gdb.
 >      During symbol reading, struct/union type gets multiply defined: struct objfile.
 >      Breakpoint 1 at 0x80f3937: file utils.c, line 799.
 >      Breakpoint 2 at 0x807c6ce: file ./cli/cli-cmds.c, line 202.
 >      (top-gdb) break main
 >      Breakpoint 3 at 0x807791c: file gdb.c, line 28.
 >      (top-gdb) run
 >      Starting program: /home/dbrueni/gdb-latest/src/gdb/gdb
 > 
 >      Breakpoint 3, main (argc=1, argv=0xbffffb14) at gdb.c:28
 >      <</home/dbrueni/gdb-latest/src/gdb/gdb.c:28:926:beg:0x807791c
 >      (top-gdb) quit
 >      The program is running.  Exit anyway? (y or n) y
 > 
 > 
 >      [dbrueni at falcon gdb]$ ./gdb -fullname -interpreter=mi ./gdb
 >      ~"GNU gdb 2002-12-10-cvs\n"
 >      ~"Copyright 2002 Free Software Foundation, Inc.\n"
 >      ~"GDB is free software, covered by the GNU General Public License, and you are\n"
 >      ~"welcome to change it and/or distribute copies of it under certain conditions.\n"
 >      ~"Type \"show copying\" to see the conditions.\n"
 >      ~"There is absolutely no warranty for GDB.  Type \"show warranty\" for details.\n"
 >      ~"This GDB was configured as \"i686-pc-linux-gnu\"..."
 >      ~"\n"
 >      ~"Setting up the environment for debugging gdb.\n"
 >      During symbol reading, struct/union type gets multiply defined: struct objfile.
 >      ~"Breakpoint 1 at 0x80f3937: file utils.c, line 799.\n"
 >      ~"Breakpoint 2 at 0x807c6ce: file ./cli/cli-cmds.c, line 202.\n"
 >      (gdb)
 >      break main
 >      &"break main\n" 
 >      ^done
 >      (gdb)
 >      run
 >      &"run\n"
 >      ^done,reason="breakpoint-hit",bkptno="3",thread-id="0",frame={addr="0x0807791c",
 >      func="main",args=[{name="argc",value="1"},{name="argv",value="0xbffffb14"}],file
 >      ="gdb.c",line="28"}
 >      (gdb)
 >      quit
 >      &"quit\n"
 >      ~"The program is running.  Exit anyway? (y or n) "
 > 
 > Notice that when the breakpoing is hit, in both cases, except for the annotation,
 > the stack location is reported using only the relative source file name (gdb.c),
 > not the fully qualified name I would expect because I used the -fullname option.
 > 
 > Example [after]:
 > 
 >      [dbrueni at falcon gdb]$ ./gdb -fullname ./gdb
 >      GNU gdb 2002-12-10-cvs
 >      Copyright 2002 Free Software Foundation, Inc.
 >      GDB is free software, covered by the GNU General Public License, and you are
 >      welcome to change it and/or distribute copies of it under certain conditions.
 >      Type "show copying" to see the conditions.
 >      There is absolutely no warranty for GDB.  Type "show warranty" for details.
 >      This GDB was configured as "i686-pc-linux-gnu"...
 >      Setting up the environment for debugging gdb.
 >      During symbol reading, struct/union type gets multiply defined: struct objfile.
 >      Breakpoint 1 at 0x80f3963: file utils.c, line 799.
 >      Breakpoint 2 at 0x807c6ce: file ./cli/cli-cmds.c, line 202.
 >      (top-gdb) break main
 >      Breakpoint 3 at 0x807791c: file gdb.c, line 28.
 >      (top-gdb) run
 >      Starting program: /home/dbrueni/gdb-latest/src/gdb/gdb
 > 
 >      Breakpoint 3, main (argc=1, argv=0xbffffb14)
 >          at /home/dbrueni/gdb-latest/src/gdb/gdb.c:28
 >      <</home/dbrueni/gdb-latest/src/gdb/gdb.c:28:926:beg:0x807791c
 >      (top-gdb) quit
 >      The program is running.  Exit anyway? (y or n) y
 > 
 > 
 >      [dbrueni at falcon gdb]$ ./gdb -fullname -interpreter=mi ./gdb
 >      ~"GNU gdb 2002-12-10-cvs\n"
 >      ~"Copyright 2002 Free Software Foundation, Inc.\n"
 >      ~"GDB is free software, covered by the GNU General Public License, and you are\n"
 >      ~"welcome to change it and/or distribute copies of it under certain conditions.\n"
 >      ~"Type \"show copying\" to see the conditions.\n"
 >      ~"There is absolutely no warranty for GDB.  Type \"show warranty\" for details.\n"
 >      ~"This GDB was configured as \"i686-pc-linux-gnu\"..."
 >      ~"\n"
 >      ~"Setting up the environment for debugging gdb.\n"
 >      During symbol reading, struct/union type gets multiply defined: struct objfile.
 >      ~"Breakpoint 1 at 0x80f3963: file utils.c, line 799.\n"
 >      ~"Breakpoint 2 at 0x807c6ce: file ./cli/cli-cmds.c, line 202.\n"
 >      (gdb)
 >      break main
 >      &"break main\n"
 >      ^done
 >      (gdb)
 >      run
 >      &"run\n"
 >      ^done,reason="breakpoint-hit",bkptno="3",thread-id="0",frame={addr="0x0807791c",
 >      func="main",args=[{name="argc",value="1"},{name="argv",value="0xbffffb14"}],file
 >      ="/home/dbrueni/gdb-latest/src/gdb/gdb.c",line="28"}
 >      (gdb)
 >      quit
 >      &"quit\n"
 >      ~"The program is running.  Exit anyway? (y or n) "
 >      y
 > 
 > 
 > 
 > 
 > Enjoy in moderation,
 > 
 > --Dennis
 > 
 > 
 > -- 
 > ----------------------------------
 > Dennis Brueni
 > Software Engineer
 > SlickEdit Inc.
 > 3000 Aerial Center Pkwy, Suite 120
 > Morrisville, NC  27560
 > Phone: 919.473.0132
 > Fax: 919.473.0080
 > dennis at slickedit dot com
 > www.slickedit.com
 > ----------------------------------
 >