Re: [RFA] i386-tdep.c: Remove call to inside_entry_file

[Mark Kettenis <kettenis at chello dot nl>]

Corinna Vinschen <vinschen at redhat dot com> writes:

> Hi,
> 
> as suggested by Andrew I'm sending this patch separately.  I've checked
> the patch for i686-pc-linux and i686-pc-cygwin.  Linux is unaffected
> (no change in testsuite results), Cygwin has additional PASSes in
> asm-source.exp.
>
> If the change is unacceptable for some reason, I'd add a new frame_chain
> function to i386-cygwin-tdep.c.  I've added this as an alternative patch.

Hi Corinna,

I'm sorry, but yes, I think the change is not obviously right.  There
are i386 targets that do not correctly terminate the frame chain, that
is, they do not mark the deepest stack frame as such by setting %ebp
to zero.  The inside_entry_file() check is there to prevent GDB from
walking off the stack on such targets.

Therefore, I think it's best to apply your alternative patch.  Your
second version is herewith approved.

Mark