This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Remove calls to inside_entry_file


On Wed, Apr 02, 2003 at 12:02:58PM -0500, Andrew Cagney wrote:



>>I'm beginning to think that reverting some of the original change:
>>
>>RFC: Mostly kill FRAME_CHAIN_VALID, add user knob
>>http://sources.redhat.com/ml/gdb-patches/2002-12/msg00683.html
>>
>>might be the best option.  What about moving this:

>
>
>I just want to make sure you realize that doing so would defeat the
>point of the patch, which was to have the other quoted checks below
>apply to all targets.  I'm trying to make the target-specific hooks
>less powerful, not more.
>
>But I guess this conversation's gone on so long that I've lost track of
>what why this is causing a problem.  So maybe I'm missing something
>important.


The original change broke assembler backtraces for at least xstormy16 and cygwin.


Right, thanks.

If we want this to work - which is explicitly a backtrace into the
entry file - then we should probably just kill the test.  If it causes
a problem somewhere, we can deal with it, but I don't expect it will.

Keep in mind that the frame_chain_valid() function has been end-of-life'ed, and the original change has been superseeded by the get_prev_frame(). Given that, I think the best thing to do is to restore the old behavior for older targets - hence put that test first.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]