This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH ARM add new set/show arm commands


> Are you suggesting I should change the option name to "set arm > disassembler"? If so, I've no problem with that. If not, what are you


Yes, just "set arm disassembler". Er, actually, is "set arm disassembler-options" better? Either name is more in line with the existing objdump --disassembler-options option.


I'm not entirely happy with the idea of forcing this method to be identical to the objdump machinery. In particular, the current objdump flags available to gdb are all prefixed by reg-names- and in gdb this is not accepted by gdb.

Further, there is another option in the arm disassembler-options command that is not available to gdb -- force-thumb. Something like this is needed for gdb, but not at this level. For gdb a proper flag that is visible to the rest of the debugger, not just the assembler is needed. Further, that flag needs to be a 3-state one, ARM, Thumb and auto. Forcing the state will affect things like breakpoint insertion etc.

I think I'd rather keep the option as "set arm disassembler" to make these distinctions clear. Thoughts?

M'kay. Can you add a note to that effect to the bug report (the i386 needs a similar treatment).


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]