This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFC: threads PREPARE_TO_PROCEED patch
- From: Mark Kettenis <kettenis at chello dot nl>
- To: Daniel Jacobowitz <drow at mvista dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 14 Mar 2003 18:20:45 +0100
- Subject: Re: RFC: threads PREPARE_TO_PROCEED patch
- References: <20030313233251.GA22466@nevyn.them.org>
Daniel Jacobowitz <drow at mvista dot com> writes:
> This patch aims to avoid problems when using a native GNU/Linux debugger
> (which supports threads) with a remote protocol stub that supports threads.
> lin_lwp_prepare_to_proceed gets called anyway, but it doesn't function,
> because the trap_ptid is (unsurprisingly) not set; since it's internal
> accounting for lin-lwp. This patch makes us use generic_prepare_to_proceed
> instead of the old default_prepare_to_proceed or lin_lwp_prepare_to_proceed;
> it can get everything it needs from infrun. If I recall correctly, it also,
> as per the FIXME, supports switching threads better than the lin_lwp version
> did. But I haven't tested that in a long time.
>
> This is a patch from last year, just before 5.3 was branched. At the time
> it was decided to be generally right, but too risky for 5.3. Well, now I've
> gone and sat on it for too long, and we're coming up on 5.4. But I've been
> using this patch since August without any problems. Depending on consensus
> I'd like to check it in either before or after we branch for release.
>
> Thoughts, thread maintainers?
I'm not quite sure whether changing the gdbarch default is a good
idea, but replacing lin_lwp_prepare_to_proceed with
generic_prepare_to_proceed has been the intention all along.
Mark