This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: Patch for corefile support
- From: Mark Kettenis <kettenis at chello dot nl>
- To: "J. Johnston" <jjohnstn at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 01 Feb 2003 14:22:02 +0100
- Subject: Re: RFA: Patch for corefile support
- References: <3E35BB3A.2020003@redhat.com>
"J. Johnston" <jjohnstn@redhat.com> writes:
> The attached patch fixes a problem in gdb when a corefile is read in
> after a multithreaded application has been debugged. What happens is that
> the thread-db and lin-lwp layers are still around and run into internal
> errors.
>
> The solution is simply to unpush the thread-db ops in its mourn_inferior
> routine. If a corefile gets loaded, there is no thread-db to interfere.
> If another multi-threaded app gets loaded, the thread_db_new_objfile is
> designed to bring back the thread-db layer as needed.
>
> This fix solves another failure in the killed.exp testsuite as well.
>
> Ok to commit?
Sorry, no. AFAICT this will break debugging programs that are
statically linked against libpthread. As a minimum, this code should
check keep_thread_db before unpushing the target, but even then, I'm
not sure whether this is really OK.
Mark