This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Unreviewed patches


Kazu Hirata wrote:
> 
> Hi,
> 
> If somebody could review these patches, that would be greatly
> appreciated.
> 
> [RFA] sim/h8300/h8300.c: Fix the handling of bxor.
> http://sources.redhat.com/ml/gdb-patches/2003-01/msg00328.html

For this one, I find the expression "!!(ea & m)" a bit obscure.
How about "(ea & m) != 0)"?


> [RFA] sim/h8300/compile.c: Fix the handling of extu.w.
> http://sources.redhat.com/ml/gdb-patches/2002-12/msg00685.html

When you say "an 8-bit wide register that does not exist", 
do you mean "that isn't simulated"?  It seems to me that 
the more correct solution is that breg[] is not big enough.
It ought to be at least 24 words, if not 32.

What do you think?

Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]